VirtualBox

source: vbox/trunk/src/VBox/Main/src-server/GraphicsAdapterImpl.cpp@ 105879

Last change on this file since 105879 was 105879, checked in by vboxsync, 9 months ago

Main/GraphicsAdapterImpl: Commented out #ifndef in isFeatureEnabled causing error messages on VM startup on arm. See todo for details. bugref:10749

  • Property svn:eol-style set to native
  • Property svn:keywords set to Author Date Id Revision
File size: 12.9 KB
Line 
1/* $Id: GraphicsAdapterImpl.cpp 105879 2024-08-28 00:04:09Z vboxsync $ */
2/** @file
3 * Implementation of IGraphicsAdapter in VBoxSVC.
4 */
5
6/*
7 * Copyright (C) 2004-2023 Oracle and/or its affiliates.
8 *
9 * This file is part of VirtualBox base platform packages, as
10 * available from https://www.215389.xyz.
11 *
12 * This program is free software; you can redistribute it and/or
13 * modify it under the terms of the GNU General Public License
14 * as published by the Free Software Foundation, in version 3 of the
15 * License.
16 *
17 * This program is distributed in the hope that it will be useful, but
18 * WITHOUT ANY WARRANTY; without even the implied warranty of
19 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
20 * General Public License for more details.
21 *
22 * You should have received a copy of the GNU General Public License
23 * along with this program; if not, see <https://www.gnu.org/licenses>.
24 *
25 * SPDX-License-Identifier: GPL-3.0-only
26 */
27
28#define LOG_GROUP LOG_GROUP_MAIN_GRAPHICSADAPTER
29
30#include "LoggingNew.h"
31
32#include "GraphicsAdapterImpl.h"
33#include "MachineImpl.h"
34
35#include "AutoStateDep.h"
36#include "AutoCaller.h"
37
38#include <iprt/cpp/utils.h>
39
40
41// constructor / destructor
42/////////////////////////////////////////////////////////////////////////////
43
44GraphicsAdapter::GraphicsAdapter() :
45 mParent(NULL)
46{}
47
48GraphicsAdapter::~GraphicsAdapter()
49{}
50
51HRESULT GraphicsAdapter::FinalConstruct()
52{
53 LogFlowThisFunc(("\n"));
54 return BaseFinalConstruct();
55}
56
57void GraphicsAdapter::FinalRelease()
58{
59 LogFlowThisFunc(("\n"));
60 uninit();
61 BaseFinalRelease();
62}
63
64// public initializer/uninitializer for internal purposes only
65/////////////////////////////////////////////////////////////////////////////
66
67/**
68 * Initializes the graphics adapter object.
69 *
70 * @param aParent Handle of the parent object.
71 */
72HRESULT GraphicsAdapter::init(Machine *aParent)
73{
74 LogFlowThisFunc(("aParent=%p\n", aParent));
75
76 ComAssertRet(aParent, E_INVALIDARG);
77
78 /* Enclose the state transition NotReady->InInit->Ready */
79 AutoInitSpan autoInitSpan(this);
80 AssertReturn(autoInitSpan.isOk(), E_FAIL);
81
82 unconst(mParent) = aParent;
83 /* mPeer is left null */
84
85 mData.allocate();
86
87 /* Confirm a successful initialization */
88 autoInitSpan.setSucceeded();
89
90 return S_OK;
91}
92
93/**
94 * Initializes the graphics adapter object given another graphics adapter
95 * object (a kind of copy constructor). This object shares data with
96 * the object passed as an argument.
97 *
98 * @note This object must be destroyed before the original object
99 * it shares data with is destroyed.
100 *
101 * @note Locks @a aThat object for reading.
102 */
103HRESULT GraphicsAdapter::init(Machine *aParent, GraphicsAdapter *aThat)
104{
105 LogFlowThisFunc(("aParent=%p, aThat=%p\n", aParent, aThat));
106
107 ComAssertRet(aParent && aThat, E_INVALIDARG);
108
109 /* Enclose the state transition NotReady->InInit->Ready */
110 AutoInitSpan autoInitSpan(this);
111 AssertReturn(autoInitSpan.isOk(), E_FAIL);
112
113 unconst(mParent) = aParent;
114 unconst(mPeer) = aThat;
115
116 AutoCaller thatCaller(aThat);
117 AssertComRCReturnRC(thatCaller.hrc());
118
119 AutoReadLock thatLock(aThat COMMA_LOCKVAL_SRC_POS);
120 mData.share(aThat->mData);
121
122 /* Confirm a successful initialization */
123 autoInitSpan.setSucceeded();
124
125 return S_OK;
126}
127
128/**
129 * Initializes the graphics adapter object given another graphics adapter
130 * object (a kind of copy constructor). This object makes a private copy
131 * of data of the original object passed as an argument.
132 *
133 * @note Locks @a aThat object for reading.
134 */
135HRESULT GraphicsAdapter::initCopy(Machine *aParent, GraphicsAdapter *aThat)
136{
137 LogFlowThisFunc(("aParent=%p, aThat=%p\n", aParent, aThat));
138
139 ComAssertRet(aParent && aThat, E_INVALIDARG);
140
141 /* Enclose the state transition NotReady->InInit->Ready */
142 AutoInitSpan autoInitSpan(this);
143 AssertReturn(autoInitSpan.isOk(), E_FAIL);
144
145 unconst(mParent) = aParent;
146 /* mPeer is left null */
147
148 AutoCaller thatCaller(aThat);
149 AssertComRCReturnRC(thatCaller.hrc());
150
151 AutoReadLock thatLock(aThat COMMA_LOCKVAL_SRC_POS);
152 mData.attachCopy(aThat->mData);
153
154 /* Confirm a successful initialization */
155 autoInitSpan.setSucceeded();
156
157 return S_OK;
158}
159
160/**
161 * Uninitializes the instance and sets the ready flag to FALSE.
162 * Called either from FinalRelease() or by the parent when it gets destroyed.
163 */
164void GraphicsAdapter::uninit()
165{
166 LogFlowThisFunc(("\n"));
167
168 /* Enclose the state transition Ready->InUninit->NotReady */
169 AutoUninitSpan autoUninitSpan(this);
170 if (autoUninitSpan.uninitDone())
171 return;
172
173 mData.free();
174
175 unconst(mPeer) = NULL;
176 unconst(mParent) = NULL;
177}
178
179// Wrapped IGraphicsAdapter properties
180/////////////////////////////////////////////////////////////////////////////
181
182HRESULT GraphicsAdapter::getGraphicsControllerType(GraphicsControllerType_T *aGraphicsControllerType)
183{
184 AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
185
186 *aGraphicsControllerType = mData->graphicsControllerType;
187
188 return S_OK;
189}
190
191HRESULT GraphicsAdapter::setGraphicsControllerType(GraphicsControllerType_T aGraphicsControllerType)
192{
193 switch (aGraphicsControllerType)
194 {
195 case GraphicsControllerType_Null:
196 case GraphicsControllerType_VBoxVGA:
197#ifdef VBOX_WITH_VMSVGA
198 case GraphicsControllerType_VMSVGA:
199 case GraphicsControllerType_VBoxSVGA:
200#endif
201 case GraphicsControllerType_QemuRamFB:
202 break;
203 default:
204 return setError(E_INVALIDARG, tr("The graphics controller type (%d) is invalid"), aGraphicsControllerType);
205 }
206
207 /* the machine needs to be mutable */
208 AutoMutableStateDependency adep(mParent);
209 if (FAILED(adep.hrc())) return adep.hrc();
210
211 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
212
213 mParent->i_setModified(Machine::IsModified_GraphicsAdapter);
214 mData.backup();
215 mData->graphicsControllerType = aGraphicsControllerType;
216
217 return S_OK;
218}
219
220HRESULT GraphicsAdapter::getVRAMSize(ULONG *aVRAMSize)
221{
222 AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
223
224 *aVRAMSize = mData->ulVRAMSizeMB;
225
226 return S_OK;
227}
228
229HRESULT GraphicsAdapter::setVRAMSize(ULONG aVRAMSize)
230{
231 /* the machine needs to be mutable */
232 AutoMutableStateDependency adep(mParent);
233 if (FAILED(adep.hrc())) return adep.hrc();
234
235 ULONG uMin, uMax;
236 HRESULT hrc = PlatformProperties::s_getSupportedVRAMRange(mData->graphicsControllerType, mData->fAccelerate3D,
237 &uMin, &uMax, NULL /* aStrideSizeMB */);
238 if (FAILED(hrc))
239 return setError(hrc,
240 tr("Error getting VRAM range for selected graphics controller"));
241
242 /* check VRAM limits */
243 if ( aVRAMSize < uMin
244 || aVRAMSize > uMax)
245 return setError(E_INVALIDARG,
246 tr("Invalid VRAM size: %lu MB (must be in range [%lu, %lu] MB)"),
247 aVRAMSize, uMin, uMax);
248
249 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
250
251 mParent->i_setModified(Machine::IsModified_GraphicsAdapter);
252 mData.backup();
253 mData->ulVRAMSizeMB = aVRAMSize;
254
255 return S_OK;
256}
257
258HRESULT GraphicsAdapter::setFeature(GraphicsFeature_T aFeature, BOOL aEnabled)
259{
260 /* the machine needs to be mutable */
261 AutoMutableStateDependency adep(mParent);
262 if (FAILED(adep.hrc())) return adep.hrc();
263
264 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
265
266 /* Validate if the given feature is supported by this graphics controller. */
267 if (!PlatformProperties::s_isGraphicsControllerFeatureSupported(mData->graphicsControllerType, aFeature))
268 return setError(VBOX_E_NOT_SUPPORTED, tr("The graphics controller does not support the given feature"));
269
270 bool *pfSetting = NULL;
271 switch (aFeature)
272 {
273 case GraphicsFeature_Acceleration2DVideo:
274 pfSetting = &mData->fAccelerate2DVideo;
275 break;
276
277 case GraphicsFeature_Acceleration3D:
278 pfSetting = &mData->fAccelerate3D;
279 break;
280
281 default:
282 break;
283 }
284
285 if (!pfSetting)
286 return setError(E_NOTIMPL, tr("The given feature is not implemented"));
287
288 if (*pfSetting != RT_BOOL(aEnabled))
289 {
290 mParent->i_setModified(Machine::IsModified_GraphicsAdapter);
291 mData.backup();
292
293 *pfSetting = RT_BOOL(aEnabled);
294 }
295
296 return S_OK;
297}
298
299HRESULT GraphicsAdapter::isFeatureEnabled(GraphicsFeature_T aFeature, BOOL *aEnabled)
300{
301 AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
302
303 bool *pfSetting = NULL;
304
305 switch (aFeature)
306 {
307/// @todo r=bird: This '#ifndef causes 2+ error messages popping up on arm when
308/// starting a VM. I don't think VBOX_E_NOT_SUPPORTED is an appropiate
309/// answer to a simple question whether a feature is supported or not. Returning
310/// FALSE would be a lot more helpful in my opinion.
311//#ifndef VBOX_WITH_VIRT_ARMV8 /* On macOS (ARM) we don't support any 2D/3D acceleration for now. */
312 case GraphicsFeature_Acceleration2DVideo:
313 pfSetting = &mData->fAccelerate2DVideo;
314 *pfSetting = false; /* @bugref{9691} -- The legacy VHWA acceleration has been disabled completely. */
315 break;
316
317 case GraphicsFeature_Acceleration3D:
318 pfSetting = &mData->fAccelerate3D;
319 break;
320//#endif
321 default:
322 break;
323 }
324
325 if (!pfSetting)
326 return VBOX_E_NOT_SUPPORTED;
327
328 *aEnabled = *pfSetting;
329
330 return S_OK;
331}
332
333HRESULT GraphicsAdapter::getMonitorCount(ULONG *aMonitorCount)
334{
335 AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
336
337 *aMonitorCount = mData->cMonitors;
338
339 return S_OK;
340}
341
342HRESULT GraphicsAdapter::setMonitorCount(ULONG aMonitorCount)
343{
344 /* make sure monitor count is a sensible number */
345 if (aMonitorCount < 1 || aMonitorCount > SchemaDefs::MaxGuestMonitors)
346 return setError(E_INVALIDARG,
347 tr("Invalid monitor count: %lu (must be in range [%lu, %lu])"),
348 aMonitorCount, 1, SchemaDefs::MaxGuestMonitors);
349
350 /* the machine needs to be mutable */
351 AutoMutableStateDependency adep(mParent);
352 if (FAILED(adep.hrc())) return adep.hrc();
353
354 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
355
356 mParent->i_setModified(Machine::IsModified_GraphicsAdapter);
357 mData.backup();
358 mData->cMonitors = aMonitorCount;
359
360 return S_OK;
361}
362
363// Wrapped IGraphicsAdapter methods
364/////////////////////////////////////////////////////////////////////////////
365
366// public methods only for internal purposes
367/////////////////////////////////////////////////////////////////////////////
368
369/**
370 * Loads settings from the given machine node.
371 * May be called once right after this object creation.
372 *
373 * @param data Configuration settings.
374 *
375 * @note Locks this object for writing.
376 */
377HRESULT GraphicsAdapter::i_loadSettings(const settings::GraphicsAdapter &data)
378{
379 AutoCaller autoCaller(this);
380 AssertComRCReturnRC(autoCaller.hrc());
381
382 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
383
384 mData.assignCopy(&data);
385
386 return S_OK;
387}
388
389/**
390 * Saves settings to the given machine node.
391 *
392 * @param data Configuration settings.
393 *
394 * @note Locks this object for reading.
395 */
396HRESULT GraphicsAdapter::i_saveSettings(settings::GraphicsAdapter &data)
397{
398 AutoCaller autoCaller(this);
399 AssertComRCReturnRC(autoCaller.hrc());
400
401 AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
402
403 data = *mData.data();
404
405 return S_OK;
406}
407
408/**
409 * @note Locks this object for writing.
410 */
411void GraphicsAdapter::i_rollback()
412{
413 /* sanity */
414 AutoCaller autoCaller(this);
415 AssertComRCReturnVoid(autoCaller.hrc());
416
417 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
418
419 mData.rollback();
420}
421
422/**
423 * @note Locks this object for writing, together with the peer object (also
424 * for writing) if there is one.
425 */
426void GraphicsAdapter::i_commit()
427{
428 /* sanity */
429 AutoCaller autoCaller(this);
430 AssertComRCReturnVoid(autoCaller.hrc());
431
432 /* sanity too */
433 AutoCaller peerCaller(mPeer);
434 AssertComRCReturnVoid(peerCaller.hrc());
435
436 /* lock both for writing since we modify both (mPeer is "master" so locked
437 * first) */
438 AutoMultiWriteLock2 alock(mPeer, this COMMA_LOCKVAL_SRC_POS);
439
440 if (mData.isBackedUp())
441 {
442 mData.commit();
443 if (mPeer)
444 {
445 /* attach new data to the peer and reshare it */
446 mPeer->mData.attach(mData);
447 }
448 }
449}
450
451/**
452 * @note Locks this object for writing, together with the peer object
453 * represented by @a aThat (locked for reading).
454 */
455void GraphicsAdapter::i_copyFrom(GraphicsAdapter *aThat)
456{
457 AssertReturnVoid(aThat != NULL);
458
459 /* sanity */
460 AutoCaller autoCaller(this);
461 AssertComRCReturnVoid(autoCaller.hrc());
462
463 /* sanity too */
464 AutoCaller thatCaller(aThat);
465 AssertComRCReturnVoid(thatCaller.hrc());
466
467 /* peer is not modified, lock it for reading (aThat is "master" so locked
468 * first) */
469 AutoReadLock rl(aThat COMMA_LOCKVAL_SRC_POS);
470 AutoWriteLock wl(this COMMA_LOCKVAL_SRC_POS);
471
472 /* this will back up current data */
473 mData.assignCopy(aThat->mData);
474}
475/* vi: set tabstop=4 shiftwidth=4 expandtab: */
Note: See TracBrowser for help on using the repository browser.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette