Changeset 20060 in vbox

Timestamp:

May 27, 2009 9:38:46 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

47800

Message:

Atomic updates of lock counters

Location:

trunk/src/VBox/VMM

Files:

• PGMInternal.h (modified) (4 diffs)
• testcase/tstVMStructGC.cpp (modified) (1 diff)

trunk/src/VBox/VMM/PGMInternal.h

@@ -38 +38 @@
 #include <VBox/hwaccm.h>
 #include <iprt/avl.h>
+#include <iprt/asm.h>
 #include <iprt/assert.h>
 #include <iprt/critsect.h>
@@ -1644 +1645 @@
      * It's a hack required because of REMR3NotifyHandlerPhysicalDeregister. */
     bool volatile       fReusedFlushPending;
+    bool                bPadding1;
+
     /** Used to indicate that this page can't be flushed. Important for cr3 root pages or shadow pae pd pages). */
-    uint8_t             cLocked;
+    uint32_t            cLocked;
 } PGMPOOLPAGE, *PPGMPOOLPAGE, **PPPGMPOOLPAGE;
 /** Pointer to a const pool page. */
@@ -4445 +4448 @@
 DECLINLINE(void) pgmPoolLockPage(PPGMPOOL pPool, PPGMPOOLPAGE pPage)
 {
-    pPage->cLocked++;
+    ASMAtomicIncU32(&pPage->cLocked);
 }
 
@@ -4458 +4461 @@
 {
     Assert(pPage->cLocked);
-    pPage->cLocked--;
+    ASMAtomicDecU32(&pPage->cLocked);
 }
 

trunk/src/VBox/VMM/testcase/tstVMStructGC.cpp

@@ -673 +673 @@
     GEN_CHECK_OFF(PGMPOOLPAGE, fCached);
     GEN_CHECK_OFF(PGMPOOLPAGE, fReusedFlushPending);
+    GEN_CHECK_OFF(PGMPOOLPAGE, cLocked);
     GEN_CHECK_SIZE(PGMPOOL);
     GEN_CHECK_OFF(PGMPOOL, pVMR3);