Changeset 22355 in vbox for trunk/src/VBox/Runtime/r0drv/linux/alloc-r0drv-linux.c

Timestamp:

Aug 19, 2009 8:09:45 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

51283

Message:

Runtime/Linux: don't allow to pass pages above 4GB to remap_page_range(); some remarks about GFP_USER

File:

• trunk/src/VBox/Runtime/r0drv/linux/alloc-r0drv-linux.c (modified) (1 diff)

trunk/src/VBox/Runtime/r0drv/linux/alloc-r0drv-linux.c

@@ -239 +239 @@
     cPages = cb >> PAGE_SHIFT;
     cOrder = CalcPowerOf2Order(cPages);
-#ifdef RT_ARCH_AMD64 /** @todo check out if there is a correct way of getting memory below 4GB (physically). */
+#ifdef RT_ARCH_AMD64
+    /** @todo check out if there is a correct way of getting memory below 4GB (physically).
+     * GFP_DMA32 is available since Linux 2.6.15 */
     paPages = alloc_pages(GFP_DMA, cOrder);
 #else
+    /** XXX Wrong: GFP_USER can return page frames above 4GB! */
     paPages = alloc_pages(GFP_USER, cOrder);
 #endif