Changeset 67806 in vbox for trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp

Timestamp:

Jul 5, 2017 3:48:20 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

116730

Message:

Devices: when attaching a driver, don't pass a local variable as description

File:

• trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp

@@ -5595 +5595 @@
     for (unsigned i = 0; i < pThis->cDeviceStates; i++)
     {
-        char szName[24];
         PLSILOGICDEVICE pDevice = &pThis->paDeviceStates[i];
 
@@ -5613 +5612 @@
         pDevice->ILed.pfnQueryStatusLed                  = lsilogicR3DeviceQueryStatusLed;
 
-        RTStrPrintf(szName, sizeof(szName), "Device%u", i);
+        char *pszName;
+        if (RTStrAPrintf(&pszName, "Device%u", i) <= 0)
+            AssertLogRelFailedReturn(VERR_NO_MEMORY);
 
         /* Attach SCSI driver. */
-        rc = PDMDevHlpDriverAttach(pDevIns, pDevice->iLUN, &pDevice->IBase, &pDevice->pDrvBase, szName);
+        rc = PDMDevHlpDriverAttach(pDevIns, pDevice->iLUN, &pDevice->IBase, &pDevice->pDrvBase, pszName);
         if (RT_SUCCESS(rc))
         {
@@ -5641 +5642 @@
             pDevice->pDrvBase = NULL;
             rc = VINF_SUCCESS;
-            Log(("LsiLogic: no driver attached to device %s\n", szName));
+            Log(("LsiLogic: no driver attached to device %s\n", pszName));
         }
         else
         {
-            AssertLogRelMsgFailed(("LsiLogic: Failed to attach %s\n", szName));
+            AssertLogRelMsgFailed(("LsiLogic: Failed to attach %s\n", pszName));
             return rc;
         }